-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prep for unified dataset schema #1414
Conversation
…dataset schema and dto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
This is a pretty major breaking change (but a good one). I think we should change the prefix to |
Also note that the change should be documented clearly in the migration page |
…dataset schema and dto
5f84530
to
b9cf5b3
Compare
5399365
to
2778acf
Compare
793b167
to
ef48549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
Description
This PR rename the current datasets DTOs and schemas and introduce a new unified dataset schema/dto.
Motivation
For historical reason, datasets were implemented with two different schemas depending if they were of type raw or derived.
This design introduced complexity in code and increased maintenance cost.
After 2 years of BE v4.x, we came to the conclusion that such differentiation is not needed and datasets can be described with a single schema and dto.
Fixes:
Changes:
Tests included
Documentation